Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1197

Merged
merged 4 commits into from Jan 24, 2023
Merged

Update README.md #1197

merged 4 commits into from Jan 24, 2023

Conversation

rakesh561
Copy link
Contributor

Added procedure to disable ipv6 during install or upgrade which was was not mentioned in the doc.

SUMMARY

ISSUE TYPE

Bug, Docs Fix or other nominal change

SUMMARY

By Default deployment tries to enable ipv6 for new install and upgrade.Recently flag was introduced to disable ipv6 but its not mentioned in the README. This will mainly help for people who are trying to upgrade or install awx from AWX 1.1.1

ISSUE TYPE

Bug, Docs Fix or other nominal change

ADDITIONAL INFORMATION

Users are running into errors with new install and upgrade ever since ipv6 had been introduced to enable

Added procedure to disable ipv6 during install or upgrade which was was not mentioned in the doc.

SUMMARY

By Default deployment tries to enable ipv6 for new install and upgrade.Recently flag was introduced to disable ipv6 but its not mentioned in the README.
This will mainly help for people who are trying to upgrade or install awx from AWX 1.1.1

ISSUE TYPE

Bug, Docs Fix or other nominal change
README.md Outdated
@@ -1285,6 +1286,24 @@ Then install the new AWX Operator by following the instructions in [Basic Instal

Once the new AWX Operator is up and running, your AWX deployment will also be upgraded.

#### Disable IPV6 for install and upgrade
Starting with AWX Operator release 0.24.0 ipv6 had been enabled in ngnix configuration which caused upgrades/new install's to fail.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rakesh561 I revised this a bit, what do you think?

Starting with  AWX Operator release 0.24.0, [IPv6 was enabled in ngnix configuration](https://github.com/ansible/awx-operator/pull/950) which causes upgrades and installs to fail in environments where IPv6 is not allowed.  Starting in  1.1.1 release, you can set the `ipv6_disabled` flag on the AWX spec.  If you need to use an AWX Operator version between 0.24.0 and 1.1.1 in an IPv6 disabled environment, it is suggested to enable ipv6 on worker nodes.

In order to disable ipv6 on ngnix configuration (awx-web container), add following to the AWX spec.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rooftopcellist Updated the requested changes it makes sense.Only thing is unable to make disable ipv6 section highlighted like other sections.

README.md Outdated
@@ -1285,6 +1286,24 @@ Then install the new AWX Operator by following the instructions in [Basic Instal

Once the new AWX Operator is up and running, your AWX deployment will also be upgraded.

#### Disable IPV6 for install and upgrade
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change the name of this section to just Disable IPv6?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rooftopcellist Updated the requested changes it makes sense.Only thing is unable to make disable ipv6 section highlighted like other sections.

Submitted the requested suggestions.
README.md Outdated
@@ -55,6 +55,7 @@ An [Ansible AWX](https://github.com/ansible/awx) operator for Kubernetes built w
* [Cluster-scope to Namespace-scope considerations](#cluster-scope-to-namespace-scope-considerations)
* [Project is now based on v1.x of the operator-sdk project](#project-is-now-based-on-v1x-of-the-operator-sdk-project)
* [Steps to upgrade](#steps-to-upgrade)
* [Disable IPV6](#IPV6)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this link work properly, you'll need:

Suggested change
* [Disable IPV6](#IPV6)
* [Disable IPV6](#disable-ipv6)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @rooftopcellist can you please check now.

README.md Outdated
@@ -1285,6 +1286,26 @@ Then install the new AWX Operator by following the instructions in [Basic Instal

Once the new AWX Operator is up and running, your AWX deployment will also be upgraded.

### Disable IPV6 ###
Starting with AWX Operator release 0.24.0,[IPV6 was enabled in ngnix configuration](https://github.com/ansible/awx-operator/pull/950) which causes
upgrades and installs to fail in environments where IPv6 is not allowed. Starting in 1.1.1 release, tou can set the `ipv6_disabled` flag on the AWX
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small typo here:

Suggested change
upgrades and installs to fail in environments where IPv6 is not allowed. Starting in 1.1.1 release, tou can set the `ipv6_disabled` flag on the AWX
upgrades and installs to fail in environments where IPv6 is not allowed. Starting in 1.1.1 release, you can set the `ipv6_disabled` flag on the AWX

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @rooftopcellist can you please check now.

Updated the requested changes
@rooftopcellist rooftopcellist enabled auto-merge (squash) January 24, 2023 04:17
@rooftopcellist
Copy link
Member

@rakesh561 Thank you for taking the time to improve the docs!

@rooftopcellist rooftopcellist merged commit 6a7c3ca into ansible:devel Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants