Fix awx-manager-role bad match between some apiGroups and resources #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealHaoLiu
approved these changes
Mar 8, 2023
rooftopcellist
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
Thanks for investigating this and putting up a fix @aurel333 !
|
@aurel333 congratulations to your first contribution in to the awx-operator project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There are some bad match between ApiGroups and Resources. This caused rights to be given to non existing resources (like APIGroup: "apps", Resource: ingress) and makes the role not creatable for an user without the
escalatepermission for Roles.With this PR, the resources are matched with only one apiGroup so the mismatched are fixed and mismatchs can be more easily avoided in the future.
Fixes #1261
ISSUE TYPE