Add websocket configuration for contour ingress #1320
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
As described in this issue, the websocket is not available through contour, as this needs special configuration.
Here is also the help page from contour.
ISSUE TYPE
ADDITIONAL INFORMATION
So this change basically implements a check if a contour ingress is installed on the cluster, and if yes, adds the websocket route, as well as the seperate path for that.
Unfortunately I wasn't able to spin up the tests, as it looks for be that these are broken somehow, if I can get these working somehow I will gladly run through them!
As well as, if any changes are wanted I will definitely try to improve the contribution.