Switch to using the sclorg redis image for consistency #1531
Conversation
roles/installer/defaults/main.yml
Outdated
| @@ -237,8 +237,8 @@ extra_volumes: '' | |||
|
|
|||
| _image: quay.io/ansible/awx | |||
| _image_version: "{{ lookup('env', 'DEFAULT_AWX_VERSION') or 'latest' }}" | |||
| _redis_image: docker.io/redis | |||
| _redis_image_version: 7 | |||
| _redis_image: quay.io/sclorg/redis-6-c8s | |||
There was a problem hiding this comment.
| _redis_image: quay.io/sclorg/redis-6-c8s | |
| _redis_image: quay.io/sclorg/redis-6-c9s |
Since the postgres 15 PR will use a c9s based container image then we should have the same thing everywhere.
What do you think ?
There was a problem hiding this comment.
Agreed, I just changed this to c9s. I'll make the same changes for eda-server-operator.
|
This requires a change to the redis.conf file to specify Completing pr #1427 would allow users to define redis.conf with or without the |
rooftopcellist
force-pushed
the
sclorg-redis-image
branch
from
b692a0d
to
1b8af22
Compare
|
Good point @Denney-tech . The path is changed in this PR, so it will work out of the box. But, I suppose there may be users who want to use redis:7 from docker, so #1427 would allow them to set a custom path for the redis data dir (in this case /var/lib/redis/data instead of /data). That other PR is largely ready to go, it just needs the merge conflicts to be resolved by the contributor. If someone has time to take over that PR and finish it up, that would be welcome. |
|
Sorry, I must have been tired yesterday when I was looking at this. Had spent all day figuring out why the sclorg images didn't work, figured it out, then found these two PR's. For some reason I didn't see the Thank you. |
|
Actually, no I wasn't crazy, the /etc/redis.conf has not been modified by this pull request and the devel image from quay now deploys the sclorg/redis image without the proper config line. roles/installer/templates/configmaps/config.yaml.j2 needs |
SUMMARY
The eda-server-operator uses the sclorg redis image as well, which is closer to what we use downstream. Consistency will improve maintainability.
New image:
ISSUE TYPE