Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pattern and max-length to secret names #1549

Merged

Conversation

imedaouidene
Copy link
Contributor

SUMMARY

Added RFC1123 validation on the secrets definied in these following properties:

  • admin_password_secret
  • old_postgres_configuration_secret
  • secret_key_secret
  • broadcast_websocket_secret

REASEON: cleanup tasks will try to create the secrets if they doesn't already exist, making the AWX instance in failing condition.
Problem obeserved when admin_password_secret was defined with the password itself not the secret's name, making the AWX instance failing.

ISSUE TYPE
  • New or Enhanced Feature
ADDITIONAL INFORMATION

@imedaouidene imedaouidene changed the title Added-patterns-max-length-to-secret-names Added pattern and max-length to secret names Aug 31, 2023
@TheRealHaoLiu
Copy link
Member

Thank you for you contribution @imedaouidene this is a good contribution and we want to merge it.

Can you take a look at the CI failures?

@rooftopcellist
Copy link
Member

Thank you for this.

Just an FYI for anyone stumbling across this in the future, these parameters are for specifying the name of the k8s secret. The k8s secrets themselves contain the sensitive values.

@fosterseth fosterseth merged commit 61921d4 into ansible:devel Sep 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants