Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix operator-hub publish script on mac #1584

Merged
merged 1 commit into from Oct 19, 2023
Merged

Fix operator-hub publish script on mac #1584

merged 1 commit into from Oct 19, 2023

Conversation

TheRealHaoLiu
Copy link
Member

SUMMARY

Remove

  • bundle/manifests/awx-operator.clusterserviceversion.yaml-e
  • bundle/metadata/annotations.yaml-e
    after generating the bundle during operator-hub publish script
ISSUE TYPE
  • Bug, Docs Fix or other nominal change
ADDITIONAL INFORMATION

dsavineau
dsavineau reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@dsavineau dsavineau left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree with the changes as a temporary workaround then I think we should try to make this script compatible with non GNU tools (especially for Mac) mainly with the sed options.

@dsavineau
Copy link
Contributor

the issue is related to the -i sed option which doesn't behave the same with the BSD and GNU version

One solution would be to always use -i.bak for all platforms (meaning backuping the source file with .bak suffix) and then remove the .bak files

@TheRealHaoLiu
Copy link
Member Author

applied the change based on @dsavineau 's recommendation

@TheRealHaoLiu TheRealHaoLiu enabled auto-merge (squash) October 19, 2023 14:24
@TheRealHaoLiu TheRealHaoLiu merged commit 293f015 into ansible:devel Oct 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsavineau dsavineau dsavineau left review comments

@rooftopcellist rooftopcellist rooftopcellist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TheRealHaoLiu @dsavineau @rooftopcellist