Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for defining loadbalancer class #1746

Merged
merged 1 commit into from Mar 6, 2024

Conversation

tylergmuir
Copy link
Contributor

SUMMARY

Adds support to define the load balancer class in Kubernetes clusters that may have multiple load balancer controllers or if a load balancer controller supports multiple classes.

ISSUE TYPE
  • New or Enhanced Feature
ADDITIONAL INFORMATION

This allows the spec.loadBalancerClass field to be specified in the operator-created service for AWX.


x-descriptors:
- urn:alm:descriptor:com.tectonic.ui:advanced
- urn:alm:descriptor:com.tectonic.ui:string
- urn:alm:descriptor:com.tectonic.ui:fieldDependency:service_type:LoadBalancer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how it currently displays. Looks good!

image

Copy link
Member

@rooftopcellist rooftopcellist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to expand upon the docs for this in a future PR. But this looks good, thanks!

@fosterseth fosterseth merged commit 82c7dd2 into ansible:devel Mar 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants