Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix incorrect command for getting ingressroutetcp resources #1778

Merged
merged 1 commit into from Apr 6, 2024

Conversation

kurokobo
Copy link
Contributor

SUMMARY

Fix incorrect command that introduced by my past PR #1757 馃槥

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
ADDITIONAL INFORMATION

@@ -86,7 +86,7 @@ spec:
!!! tip
AWX Operator supports both API groups `traefik.io` and `traefik.containo.us` in `ingress_api_version` for Traefik, but it is recommended to use `traefik.io` since `traefik.containo.us` is deprecated in Traefik v2.10 and is removed in Traefik v3. Refer to [Traefik documentation](https://doc.traefik.io/traefik/migration/v2/#v210) for more information about deprecation.

If you can't see any IngressRouteTCP resources by `kubectl` command after deploying mesh ingress, you should fully qualify the resource name with API group, `kubectl get ingressroutetcp.traefik.io` or `kubectl get traefik.containo.us` for example.
If you can't see any IngressRouteTCP resources by `kubectl` command after deploying mesh ingress, you should fully qualify the resource name with API group, `kubectl get ingressroutetcp.traefik.io` or `kubectl get ingressroutetcp.traefik.containo.us` for example.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kurokobo The example in the TraefikLabs docs seems to be:

ingressroutetcps.traefik.io

https://doc.traefik.io/traefik/routing/providers/kubernetes-crd/

I also see: ingressroutes.traefik.containo.us

But I don't see an example of ingressroutetcp.traefik.containo.us. Could you link to the docs for that?

Copy link
Contributor Author

@kurokobo kurokobo Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rooftopcellist
Hi, thanks for your confirmation.

https://doc.traefik.io/traefik/routing/providers/kubernetes-crd/

This page contains both ingressroutetcps.traefik.io and ingressroutetcps.traefik.containo.us (search with plural form, ingressroutetcps... instead of ingressroutetcp...).

We can find actual CRDs here (since master branch is for 3.x and any containo.us had been removed, refer to the file in v2.x branch): https://github.com/traefik/traefik/blob/v2.11/docs/content/reference/dynamic-configuration/kubernetes-crd-definition-v1.yml

$ curl -s https://raw.githubusercontent.com/traefik/traefik/v2.11/docs/content/reference/dynamic-configuration/kubernetes-crd-definition-v1.yml | grep "name: ingressroutetcps"
  name: ingressroutetcps.traefik.io
  name: ingressroutetcps.traefik.containo.us

@rooftopcellist rooftopcellist merged commit 413b700 into ansible:devel Apr 6, 2024
6 checks passed
@kurokobo kurokobo deleted the docs_traefik branch April 6, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants