Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add noxfile and workflow to test docsite PRs #1794

Merged
merged 4 commits into from Mar 27, 2024
Merged

Add noxfile and workflow to test docsite PRs #1794

merged 4 commits into from Mar 27, 2024

Conversation

oraNod
Copy link
Contributor

@oraNod oraNod commented Mar 26, 2024

SUMMARY

Resolves #1685 with the following changes:

  • Adds noxfile with a session to build the docsite with mkdocs in strict mode
  • Adds a reusable nox workflow that includes the build session
  • Updates the "devel" workflow to trigger the nox workflow
ISSUE TYPE
  • Bug, Docs Fix or other nominal change
ADDITIONAL INFORMATION

N/A

@oraNod oraNod added component:docs Improvements or additions to documentation community and removed community labels Mar 26, 2024
@oraNod
Copy link
Contributor Author

oraNod commented Mar 26, 2024

Hmm. Maybe it's better to include the workflow in the ci.yaml instead of devel.yaml... I think I chose the wrong one.

tvo318
tvo318 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@tvo318 tvo318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Seth says it's ok, then I approve

@rooftopcellist rooftopcellist merged commit dc0e86b into ansible:devel Mar 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvo318 tvo318 tvo318 approved these changes

@fosterseth fosterseth fosterseth approved these changes

@rooftopcellist rooftopcellist rooftopcellist approved these changes

Assignees
No one assigned
Labels
community component:docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Add check for building docs
4 participants
@oraNod @tvo318 @fosterseth @rooftopcellist