Pre-create dummy rh secret to avoid errors #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlopez133
reviewed
Jul 22, 2022
rooftopcellist
force-pushed
the
fix-rh-ops-secret
branch
from
68d1d43
to
746d604
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #922
For a particular disconnected deployment scenario, it was necessary to add an "expected" secret in order to pull the operator container image.
Adding this had an undesired side-effect: errors in the logs when trying to find the pull secret. There is nothing functionally wrong with the resulting deployment, but the logs are annoying, so this creates a dummy secret to remedy that.
ISSUE TYPE