Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove output/stderr tabs from host detail modals when not present #12064

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

keithjgrant
Copy link
Member

SUMMARY
  • Fixes issues in Host Detail modal where output was sometimes not displayed.
  • Hides the Output and Standard Out tabs from the modal when they are empty

Screen Shot 2022-04-18 at 9 23 47 AM

Screen Shot 2022-04-18 at 9 24 25 AM

addresses #11068

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • UI

Copy link
Member

@marshmalien marshmalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out locally and I like the improvements you've added to getStdOutValue. Thanks for cleaning up the bug where we only displayed the first item in the results array. Great work!

@InnocentK InnocentK self-assigned this Apr 18, 2022
@cypress
Copy link

cypress bot commented Apr 19, 2022



Test summary

636 5 842 0Flakiness 2


Run details

Project AWX - Functional
Status Failed
Commit 51fe39f
Started Apr 19, 2022 6:01 PM
Ended Apr 19, 2022 7:49 PM
Duration 48:07 💡
OS Linux Debian - 11.3
Browser Chrome 99

View run in Cypress Dashboard ➡️


Failures

inventories/inventory-adhoc-commands.spec.js Failed
1 Inventory Hosts Ad Hoc Commands > Can launch an adhoc command against an inventory host
2 Inventory Groups -> Related groups Ad Hoc Commands > can run command against a single related group
3 Inventory Groups -> Related groups Ad Hoc Commands > can run command against multiple related groups
inventories/inventory-sources.spec.js Failed
1 Inventory Source Details Page > Can sync the source with the inventory
projects/project-list.spec.js Failed
1 Project list navigation and sort > can cancel a project sync

Flakiness

dashboard/dashboard.spec.js Flakiness
1 Dashboard Counts button - Hosts > Dashboard Counts button for Hosts shows correct count and navigates correctly when clicked
inventories/inventory-adhoc-commands.spec.js Flakiness
1 Inventory Group Ad Hoc Commands > Can launch an adhoc command against an inventory group

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@InnocentK InnocentK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants