Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Don't double-entity encode on event stdout #12950

Merged
merged 1 commit into from
Sep 28, 2022
Merged

[ui] Don't double-entity encode on event stdout #12950

merged 1 commit into from
Sep 28, 2022

Conversation

relrod
Copy link
Member

@relrod relrod commented Sep 24, 2022

SUMMARY
  • stdout output on events was being double HTML entity encoded meaning that all output with < and > was shown as literal &lt; and &gt;

NOTE This needs some review, I'm not confident if there are any XSS implications here or cases where we do need to run the escaping logic.

refs #9062

and #12064 which fixed this for stderr but not stdout

Before:
image

After:
image

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • UI
AWX VERSION
awx: 21.6.1.dev52+g93f50b5211

@relrod
[ui] Don't double-entity encode on event stdout
98c7b1b 
- stdout output on events was being double HTML entity encoded meaning
  that all output with < and > was shown as literal "&lt;" and "&gt;"
@relrod relrod merged commit 1b46805 into ansible:devel Sep 28, 2022
@relrod relrod mentioned this pull request Sep 28, 2022
Closed
sarabrajsingh pushed a commit to sarabrajsingh/awx that referenced this pull request Oct 3, 2022
@relrod @sarabrajsingh
[ui] Don't double-entity encode on event stdout (ansible#12950)
d2cfd8f 
- stdout output on events was being double HTML entity encoded meaning
  that all output with < and > was shown as literal "&lt;" and "&gt;"

Signed-off-by: Rick Elrod <rick@elrod.me>
sarabrajsingh pushed a commit to sarabrajsingh/awx that referenced this pull request Oct 3, 2022
@relrod @sarabrajsingh
[ui] Don't double-entity encode on event stdout (ansible#12950)
69d6bf2 
- stdout output on events was being double HTML entity encoded meaning
  that all output with < and > was shown as literal "&lt;" and "&gt;"

Signed-off-by: Rick Elrod <rick@elrod.me>
AlexSCorey pushed a commit that referenced this pull request Oct 11, 2022
@relrod @AlexSCorey
[ui] Don't double-entity encode on event stdout (#12950)
753959a 
- stdout output on events was being double HTML entity encoded meaning
  that all output with < and > was shown as literal "&lt;" and "&gt;"

Signed-off-by: Rick Elrod <rick@elrod.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithjgrant keithjgrant keithjgrant approved these changes

@AlexSCorey AlexSCorey Awaiting requested review from AlexSCorey

@mabashian mabashian Awaiting requested review from mabashian

Assignees
No one assigned
Labels
component:ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@relrod @keithjgrant