Don't repeatedly traverse workflow nodes when finding ancestors #12156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In this function: https://github.com/ansible/awx/blob/devel/awx/ui/src/components/Workflow/workflowReducer.js#L535-L584 we go through and mark ancestor nodes as disabled to prevent users from building a workflow with a cycle in it. If you build a workflow with a sufficiently large number of paths back to the start node and then attempt to link one of the very end nodes with another, the visualizer will crash (due to long running recursion).
To fix this, I've marked nodes as "already traversed" to prevent us from traversing the same paths over and over.
ISSUE TYPE
COMPONENT NAME