Make /api/v2/workflow_approvals/ endpoint read-only #13593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanCoding
approved these changes
Feb 17, 2023
included workflow approval as a read only endpoint to pass collection tests
gamuniz
force-pushed
the
fix_workflowapproval_view
branch
from
bbe2a4d
to
fb2647f
Compare
github-actions
bot
added
the
component:awx_collection
gamuniz
changed the title
shanemcd
approved these changes
Feb 17, 2023
shanemcd
changed the title
|
@gamuniz - will this be back-ported to 4.3 and 4.2? |
|
@tvo318 After discussing this with @AlanCoding this will not be back ported to earlier versions, it might require we document that this endpoint was never intended to be posted to in the tips and tricks or known issues portion of the documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently the workflow_approvals endpoint allows posts which are unnecessary and by themselves are not useful. This changes the parent class to one which only allows list.
If someone is trying to approve or deny a workflow approval the correct endpoint would be:
/api/v2/workflow_approvals/N/approve/
api/v2/workflow_approvals/N/deny/
Where N is the id of the approval.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION