Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test and docs for workflow_approval module #13594

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

AlanCoding
Copy link
Member

SUMMARY

Related to #13593, I don't want someone else to waste the time I did today on this.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API
ADDITIONAL INFORMATION

I got a playbook that worked, so I wanted to get the data in.

If you put the name in the wrong place (identifier field, obviously) then you get no feedback until it times out, and then all you know is that it times out. So as you can see, this is trying to call that out as an important detail.

@github-actions github-actions bot added the component:awx_collection issues related to the collection for controlling AWX label Feb 17, 2023
@AlanCoding
Copy link
Member Author

Tested via:

$ ansible-playbook -i localhost testing/integration.yml -e test=workflow_approval
[WARNING]: You are running the development version of Ansible. You should only run Ansible from "devel" if you are
modifying the Ansible engine, or trying out features under development. This is a rapidly changing source of code and can
become unstable at any point.
[WARNING]: Unable to parse /home/alancoding/repos/awx/localhost as an inventory source
[WARNING]: No inventory was parsed, only implicit localhost is available
[WARNING]: provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match
'all'
[DEPRECATION WARNING]: "include" is deprecated, use include_tasks/import_tasks instead. See 
https://docs.ansible.com/ansible-core/devel/user_guide/playbooks_reuse_includes.html for details. This feature will be 
removed in version 2.16. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.

PLAY [localhost] **********************************************************************************************************

TASK [Include all targets] ************************************************************************************************
skipping: [localhost] => (item=inventory_source_update) 
skipping: [localhost] => (item=group) 
skipping: [localhost] => (item=instance) 
skipping: [localhost] => (item=ad_hoc_command_cancel) 
skipping: [localhost] => (item=ad_hoc_command) 
skipping: [localhost] => (item=notification_template) 
skipping: [localhost] => (item=execution_environment) 
skipping: [localhost] => (item=label) 
skipping: [localhost] => (item=team) 
skipping: [localhost] => (item=role) 
skipping: [localhost] => (item=token) 
skipping: [localhost] => (item=job_launch) 
skipping: [localhost] => (item=application) 
skipping: [localhost] => (item=organization) 
skipping: [localhost] => (item=workflow_launch) 
skipping: [localhost] => (item=credential_input_source) 
skipping: [localhost] => (item=user) 
skipping: [localhost] => (item=inventory_source) 
skipping: [localhost] => (item=job_list) 
skipping: [localhost] => (item=workflow_approval) 
skipping: [localhost] => (item=export) 
skipping: [localhost] => (item=job_cancel) 
skipping: [localhost] => (item=host) 
skipping: [localhost] => (item=schedule) 
skipping: [localhost] => (item=ad_hoc_command_wait) 
skipping: [localhost] => (item=job_wait) 
skipping: [localhost] => (item=lookup_api_plugin) 
skipping: [localhost] => (item=inventory) 
skipping: [localhost] => (item=project_manual) 
skipping: [localhost] => (item=job_template) 
skipping: [localhost] => (item=credential) 
skipping: [localhost] => (item=credential_type) 
skipping: [localhost] => (item=import) 
skipping: [localhost] => (item=lookup_rruleset) 
skipping: [localhost] => (item=schedule_rrule) 
skipping: [localhost] => (item=project_update) 
skipping: [localhost] => (item=demo_data) 
skipping: [localhost] => (item=instance_group) 
skipping: [localhost] => (item=workflow_job_template) 
skipping: [localhost] => (item=project) 
skipping: [localhost] => (item=settings) 
skipping: [localhost] => (item=inventory_source_update/tasks) 
skipping: [localhost] => (item=inventory_source_update/tasks/main.yml) 
skipping: [localhost] => (item=group/tasks) 
skipping: [localhost] => (item=group/tasks/main.yml) 
skipping: [localhost] => (item=instance/tasks) 
skipping: [localhost] => (item=instance/tasks/main.yml) 
skipping: [localhost] => (item=ad_hoc_command_cancel/tasks) 
skipping: [localhost] => (item=ad_hoc_command_cancel/tasks/main.yml) 
skipping: [localhost] => (item=ad_hoc_command/tasks) 
skipping: [localhost] => (item=ad_hoc_command/tasks/main.yml) 
skipping: [localhost] => (item=notification_template/tasks) 
skipping: [localhost] => (item=notification_template/tasks/main.yml) 
skipping: [localhost] => (item=execution_environment/tasks) 
skipping: [localhost] => (item=execution_environment/tasks/main.yml) 
skipping: [localhost] => (item=label/tasks) 
skipping: [localhost] => (item=label/tasks/main.yml) 
skipping: [localhost] => (item=team/tasks) 
skipping: [localhost] => (item=team/tasks/main.yml) 
skipping: [localhost] => (item=role/tasks) 
skipping: [localhost] => (item=role/tasks/main.yml) 
skipping: [localhost] => (item=token/tasks) 
skipping: [localhost] => (item=token/tasks/main.yml) 
skipping: [localhost] => (item=job_launch/tasks) 
skipping: [localhost] => (item=job_launch/tasks/main.yml) 
skipping: [localhost] => (item=application/tasks) 
skipping: [localhost] => (item=application/tasks/main.yml) 
skipping: [localhost] => (item=organization/tasks) 
skipping: [localhost] => (item=organization/tasks/main.yml) 
skipping: [localhost] => (item=workflow_launch/tasks) 
skipping: [localhost] => (item=workflow_launch/tasks/main.yml) 
skipping: [localhost] => (item=credential_input_source/tasks) 
skipping: [localhost] => (item=credential_input_source/tasks/main.yml) 
skipping: [localhost] => (item=user/tasks) 
skipping: [localhost] => (item=user/tasks/main.yml) 
skipping: [localhost] => (item=inventory_source/tasks) 
skipping: [localhost] => (item=inventory_source/tasks/main.yml) 
skipping: [localhost] => (item=job_list/tasks) 
skipping: [localhost] => (item=job_list/tasks/main.yml) 
skipping: [localhost] => (item=workflow_approval/tasks) 
skipping: [localhost] => (item=export/tasks) 
skipping: [localhost] => (item=export/aliases) 
skipping: [localhost] => (item=export/tasks/main.yml) 
skipping: [localhost] => (item=job_cancel/tasks) 
skipping: [localhost] => (item=job_cancel/tasks/main.yml) 
skipping: [localhost] => (item=host/tasks) 
skipping: [localhost] => (item=host/tasks/main.yml) 
skipping: [localhost] => (item=schedule/tasks) 
skipping: [localhost] => (item=schedule/tasks/main.yml) 
skipping: [localhost] => (item=ad_hoc_command_wait/tasks) 
skipping: [localhost] => (item=ad_hoc_command_wait/tasks/main.yml) 
skipping: [localhost] => (item=job_wait/tasks) 
skipping: [localhost] => (item=job_wait/tasks/main.yml) 
skipping: [localhost] => (item=lookup_api_plugin/tasks) 
skipping: [localhost] => (item=lookup_api_plugin/tasks/main.yml) 
skipping: [localhost] => (item=inventory/tasks) 
skipping: [localhost] => (item=inventory/tasks/main.yml) 
skipping: [localhost] => (item=project_manual/tasks) 
skipping: [localhost] => (item=project_manual/tasks/create_project_dir.yml) 
skipping: [localhost] => (item=project_manual/tasks/main.yml) 
skipping: [localhost] => (item=job_template/tasks) 
skipping: [localhost] => (item=job_template/tasks/main.yml) 
skipping: [localhost] => (item=credential/tasks) 
skipping: [localhost] => (item=credential/tasks/main.yml) 
skipping: [localhost] => (item=credential_type/tasks) 
skipping: [localhost] => (item=credential_type/tasks/main.yml) 
skipping: [localhost] => (item=import/tasks) 
skipping: [localhost] => (item=import/aliases) 
skipping: [localhost] => (item=import/tasks/main.yml) 
skipping: [localhost] => (item=lookup_rruleset/tasks) 
skipping: [localhost] => (item=lookup_rruleset/tasks/main.yml) 
skipping: [localhost] => (item=schedule_rrule/tasks) 
skipping: [localhost] => (item=schedule_rrule/tasks/main.yml) 
skipping: [localhost] => (item=project_update/tasks) 
skipping: [localhost] => (item=project_update/tasks/main.yml) 
skipping: [localhost] => (item=demo_data/tasks) 
skipping: [localhost] => (item=demo_data/tasks/main.yml) 
skipping: [localhost] => (item=instance_group/tasks) 
skipping: [localhost] => (item=instance_group/tasks/main.yml) 
skipping: [localhost] => (item=workflow_job_template/tasks) 
skipping: [localhost] => (item=workflow_job_template/tasks/main.yml) 
skipping: [localhost] => (item=project/tasks) 
skipping: [localhost] => (item=project/tasks/main.yml) 
skipping: [localhost] => (item=settings/tasks) 
skipping: [localhost] => (item=settings/tasks/main.yml) 
[DEPRECATION WARNING]: "include" is deprecated, use include_tasks/import_tasks/import_playbook instead. This feature will 
be removed in version 2.16. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
included: /home/alancoding/repos/awx/awx_collection/tests/integration/targets/workflow_approval/tasks/main.yml for localhost => (item=workflow_approval/tasks/main.yml)

TASK [Generate a random string for names] *********************************************************************************
ok: [localhost]

TASK [Generate random names for test objects] *****************************************************************************
ok: [localhost]

TASK [Create a new organization for test isolation] ***********************************************************************
[WARNING]: You are running collection version 0.0.1-devel but connecting to AWX version 21.11.1.dev27+g0815f935ca
changed: [localhost]

TASK [Create a workflow job template] *************************************************************************************
changed: [localhost]

TASK [Create approval node] ***********************************************************************************************
changed: [localhost]

TASK [Launch the workflow] ************************************************************************************************
changed: [localhost]

TASK [Wait for approval node to activate and approve] *********************************************************************
changed: [localhost]

TASK [assert] *************************************************************************************************************
ok: [localhost] => {
    "changed": false,
    "msg": "All assertions passed"
}

TASK [Delete the workflow job template] ***********************************************************************************
changed: [localhost]

PLAY RECAP ****************************************************************************************************************
localhost                  : ok=10   changed=6    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   

@AlanCoding AlanCoding merged commit a3233b5 into ansible:devel Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:awx_collection issues related to the collection for controlling AWX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants