Consolidate get_queryset methods #13906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamuniz
approved these changes
Apr 26, 2023
|
I kicked off integration tests, if those come back looking good I'll come back and merge. |
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Apr 28, 2023
In a prior merge, we added the ability to slap filter_read_permission = False on a view to get a certain functionality where it didn't filter a sublist the view is showing. This logic already existed in a highly duplicated form among a number of views, so this deletes those methods in favor of the flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
With a recent merge #13676, we added the ability to slap
filter_read_permission = Falseon a view to get a certain functionality where it didn't filter a sublist the view is showing.This logic already existed in a highly duplicated form among a number of views, so this deletes those methods in favor of the flag.
ISSUE TYPE
COMPONENT NAME