Fix bug with parent_key filtering #13957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-westcott-iv
approved these changes
May 5, 2023
AlanCoding
added a commit
that referenced
this pull request
May 10, 2023
This was caused by an incorrect parent_key ref from label to job also applies to workflow_job labels This fixes a regression introduced by a recent merge (#13957)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I introduced this bug with the merge of #13906, and it was unfortunately fairly high-consequence.
The "new" logic was just fine, but the problem is that the
parent_keyspecification dropped us into theget_querysetof a subclass, which I... didn't expect.This doubles-down on the refactor, and merges those two methods together. So far, it addresses the test case that was found to be failing.
ISSUE TYPE
COMPONENT NAME