Pass existing object references within access methods #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids re-loading objects from the database in our chain of permission checking, wherever possible. access.py is equiped to handle object references instead of pk ints, and permissions.py is changed to pass those refs.
matburt
approved these changes
Sep 8, 2017
mabashian
pushed a commit
to mabashian/awx
that referenced
this pull request
Jun 28, 2019
pages unit tests
kdelee
pushed a commit
that referenced
this pull request
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just looking at
/inventories/N/hosts/, we retrieve the inventory (pk=N) 6 distinct times. This is because we had a habit of passing the pk from one piece of code to another, at which point the 2nd piece of code would go turn the pk into a python object. With this change, the method is called 0 for a GET to that endpoint, because the view constructs its own lookup.I argue that this revision actually leaves us with fewer moving parts and better modularization.
Signed-off-by: Alan Rominger arominge@redhat.com