Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ee_reference.rst: refert to Builder's definition docs instead of duplicating its content #14562

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

Andersson007
Copy link
Contributor

@Andersson007 Andersson007 commented Oct 11, 2023

SUMMARY

https://docs.ansible.com/automation-controller/latest/html/userguide/ee_reference.html#execution-environment-definition duplicates content from Builder's docs, so we'll be just referring to it to avoid divergence and confusion.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Docs
AWX VERSION
latest

@Andersson007 Andersson007 changed the title ee_reference.rst: refert to Builder's definition docs instead of dupl… ee_reference.rst: refert to Builder's definition docs instead of duplicating its content Oct 11, 2023
@Andersson007
Copy link
Contributor Author

ready_for_review

@gundalow gundalow merged commit 160634f into ansible:devel Oct 11, 2023
23 checks passed
@Andersson007
Copy link
Contributor Author

@jbericat @Zokormazo @gundalow thanks for reviewing and merging!

@tvo318
Copy link
Member

tvo318 commented Oct 24, 2023

@Andersson007 @gundalow - So the reason why we put the builder v3 content in the automation controller docs was because I was told that we don't want to reference upstream docs for downstream readers. If that is ok, then I'll know next time where duplicate content exist to not duplicate the content.

@Andersson007
Copy link
Contributor Author

@tvo318 thanks for the context, if you recall the rationale for that, it'd be great, maybe it's reasonable, i don't know, but if we use builder to build the images i think we should refer to their docs as it's the most relevant and updated, etc.

djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants