New setting for pg_notify listener DB settings, add keepalive #14755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealHaoLiu
added a commit
to TheRealHaoLiu/awx-operator
that referenced
this pull request
Jan 16, 2024
Related to ansible/awx#14755 move TCP keepalive to pg_listener specific db setting
chrismeyersfsu
approved these changes
Jan 16, 2024
TheRealHaoLiu
added a commit
to ansible/awx-operator
that referenced
this pull request
Jan 17, 2024
Related to ansible/awx#14755 move TCP keepalive to pg_listener specific db setting
AlanCoding
added a commit
to AlanCoding/awx
that referenced
this pull request
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This solves the same problem as #14749
This does effectively re-do some of what ansible/awx-operator#1393 does. I would suggest that those awx-operator settings should then be modified to edit
LISTENER_DATABASESas opposed toDATABASES.The benefit of this is that we do not add the keealive messages to the ordinary connections, of which there may be many. In many deployments, max connections is set to 1024... so this seems potentially excessive, even if they are lightweight. But maybe it's not a big deal and we could just close this and keep to the old approach. I just want to fully volunteer what this looks like.
Tested and works for the steps I described in 14749.
ISSUE TYPE
COMPONENT NAME