Add ability to configure Postgres keepalive settings #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealHaoLiu
force-pushed
the
feature_keepalive
branch
3 times, most recently
from
673cf2e
to
99bfff2
Compare
AlanCoding
approved these changes
May 8, 2023
TheRealHaoLiu
force-pushed
the
feature_keepalive
branch
2 times, most recently
from
f673cba
to
52933da
Compare
rooftopcellist
approved these changes
May 9, 2023
TheRealHaoLiu
force-pushed
the
feature_keepalive
branch
from
52933da
to
a649e78
Compare
Co-Authored-By: Gabriel Muniz <gmuniz@redhat.com> Co-Authored-By: Rick Elrod <rick@elrod.me>
TheRealHaoLiu
force-pushed
the
feature_keepalive
branch
from
a649e78
to
4a86999
Compare
shanemcd
approved these changes
May 11, 2023
shanemcd
changed the title
Closed
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
During our test for DB failover we notice that dispatcher will hang and keep polling a idle (and dead) database connection after database failover happens, this PR will use TCP keepalive to kill the dead TCP connection and allow dispatcher to reconnect and able to handle DB failover
ISSUE TYPE
ADDITIONAL INFORMATION