plugins/tower.py: Use urllib.parse rather than urlparse

[Spredzy]

SUMMARY

urlparse does not exist in python3, it has been replaced by urllib.parse

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

• API

AWX VERSION

• devel

ADDITIONAL INFORMATION

• N/A

[softwarefactory-project-zuul]

Build succeeded.

• tox-awx-api-lint : SUCCESS in 2m 10s
• tox-awx-ui-lint : SUCCESS in 2m 20s
• tox-awx-api : SUCCESS in 6m 21s
• tox-awx-ui : SUCCESS in 4m 11s
• tox-awx-swagger : SUCCESS in 6m 54s
• tox-awx-detect-schema-change : SUCCESS in 6m 07s (non-voting)

[AlanCoding]

This is quite similar in nature to:

#3305

We have not committed to supporting inventory updates via scripts in python3 virtual environments. This shouldn't be a formal test objective.

We will absolutely support inventory updates via plugins in python3 virtual environments, including the default virtual environment.

However, it remains extremely important that tower.py continues to work in python2.

$ python
Python 2.7.11 (default, Oct 17 2016, 14:59:40) 
[GCC 4.2.1 Compatible Apple LLVM 7.0.2 (clang-700.1.81)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from urllib.parse import urljoin
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: No module named parse

At best, you could do a conditional import. I wouldn't object to that, but it would still be officially unsupported to run it in python3.

[ryanpetrello]

I'm not against just saying this one only works in py2, personally (especially if Tower inv plugins are on by default after @AlanCoding's PR merges).

[ryanpetrello]

If we do this, we should at least make this 2/3 compatible:

try:
    from urlparse import urljoin
except ImportError:
    from urllib.parse import urljoin

[wenottingham]

We have not committed to supporting inventory updates via scripts in python3 virtual environments. This shouldn't be a formal test objective.

We'll have either python2 or python3 for the ansible-inventory environment depending on OS; ergo, I would expect customer scripts to potentially be run in either depending on their deployment platform.

[softwarefactory-project-zuul]

Build succeeded.

• tox-awx-api-lint : SUCCESS in 2m 13s
• tox-awx-ui-lint : SUCCESS in 2m 36s
• tox-awx-api : SUCCESS in 5m 37s
• tox-awx-ui : SUCCESS in 3m 57s
• tox-awx-swagger : SUCCESS in 6m 16s
• tox-awx-detect-schema-change : SUCCESS in 6m 28s (non-voting)

[softwarefactory-project-zuul]

Build succeeded (gate pipeline).

• tox-awx-api-lint : SUCCESS in 2m 00s
• tox-awx-ui-lint : SUCCESS in 3m 10s
• tox-awx-api : SUCCESS in 5m 57s
• tox-awx-ui : SUCCESS in 3m 42s
• tox-awx-swagger : SUCCESS in 6m 49s
• tox-awx-detect-schema-change : SUCCESS in 6m 39s (non-voting)
• awx-push-new-schema : SUCCESS in 5m 56s (non-voting)