[option2] Handle schedule computed fields no-ops, keep disabled next_run behavior #3936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continue practice of setting a next_run value for disabled schedules Bail if no fields are changed Do not update related template if its fields did not change Keeping updates to disabled schedules, we still must call related template computed fields on every save because it's non-obvious if schedule was enabled / disabled Change call pattern to schedule.update_computed_fields() in doing so, fix bug where template does not pick up schedule due to schedules next_run not being saved Handle the case (also a bug) where template was not updated when schedule was deleted
|
Build succeeded.
|
This was referenced Sep 5, 2021
This was referenced Oct 6, 2022
This was referenced Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Put simply, this is a more conservative version of #3933
Connect #3912
I had second thoughts about not updating
next_runfor disabled schedules. It shouldn't be that expensive, and I still believe that this change will be plenty sufficient to resolve the linked issue. This PR keeps the behavior where we updatenext_runfor disabled schedules.ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION