Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install a newer version of sqlite in the development image #4198

Closed
wants to merge 1 commit into from
Closed

Install a newer version of sqlite in the development image #4198

wants to merge 1 commit into from

Conversation

shanemcd
Copy link
Member

@shanemcd shanemcd commented Jul 1, 2019

No description provided.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@jbradberry jbradberry mentioned this pull request Jul 1, 2019
Merged
rooftopcellist
rooftopcellist approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@rooftopcellist rooftopcellist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this just needs to be rebased before merging so the ui tests pass @shanemcd

@ryanpetrello
Copy link
Contributor

ryanpetrello commented Jul 3, 2019 •
edited
Loading

@jbradberry can you give this a whirl, and see if it unblocks you?

@jbradberry
Copy link
Contributor

@jbradberry can you give this a whirl, and see if it unblocks you?

@ryanpetrello I can't at the current time, but what I was using (aside from letting Django 2.2 try to run) was running from the bash command line, python -c "import sqlite3; print(sqlite3.sqlite_version)". If it shows the new version, it should be good. Also if running the tests work.

jbradberry
jbradberry suggested changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@jbradberry jbradberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

(awx) bash-4.2$ sqlite3 --version
3.28.0 2019-04-16 19:49:53 884b4b7e502b4e991677b53971277adfaf0a04a284f8e483e2553d0f83156b50
(awx) bash-4.2$ python -c "import sqlite3; print(sqlite3.sqlite_version)"
3.7.17

I'm afraid that this is not sufficient.

@jbradberry
Copy link
Contributor 

(awx) bash-4.2$ make test
Traceback (most recent call last):
  File "/venv/awx/bin/py.test", line 11, in <module>
    sys.exit(main())
  ... redacted ...
  File "/venv/awx/lib64/python3.6/site-packages/django/db/backends/sqlite3/base.py", line 66, in <module>
    check_sqlite_version()
  File "/venv/awx/lib64/python3.6/site-packages/django/db/backends/sqlite3/base.py", line 63, in check_sqlite_version
    raise ImproperlyConfigured('SQLite 3.8.3 or later is required (found %s).' % Database.sqlite_version)
django.core.exceptions.ImproperlyConfigured: SQLite 3.8.3 or later is required (found 3.7.17).
make: *** [test] Error 1

@shanemcd
Copy link
Member Author

shanemcd commented Jul 8, 2019

Doesnt work, closing this.

@shanemcd shanemcd closed this Jul 8, 2019
fosterseth added a commit to fosterseth/awx that referenced this pull request Apr 2, 2020
@fosterseth
Allow orphaned user to be added to org
c32dfd4 
Fixed bug where an org admin was not able to add
an orphaned user to the org, in the case where the
orphan had an ancestor role that matched one of the
roles for of the org admin.

scenario to fix -- sue is member of cred1, where cred1 is
part of org1. org1 admin cannot add sue to org1, because
the cred1 role for sue has an ancestor to org1 role. The org1
admin cannot change or attach sue to org1.

issue ansible#4198 and ansible#4197
fosterseth added a commit to fosterseth/awx that referenced this pull request Apr 2, 2020
@fosterseth
Allow orphaned user to be added to org
2730734 
Fixed bug where an org admin was not able to add
an orphaned user to the org, in the case where the
orphan had an ancestor role that matched one of the
roles for of the org admin.

scenario to fix -- sue is member of cred1, where cred1 is
part of org1. org1 admin cannot add sue to org1, because
the cred1 role for sue has an ancestor to org1 role. The org1
admin cannot change or attach sue to org1.

issue ansible#4198 and ansible#4197
fosterseth added a commit to fosterseth/awx that referenced this pull request Apr 2, 2020
@fosterseth
Allow orphaned user to be added to org
f120ea7 
Fixed bug where an org admin was not able to add
an orphaned user to the org, in the case where the
orphan had an ancestor role that matched one of the
roles for of the org admin.

scenario to fix -- sue is member of cred1, where cred1 is
part of org1. org1 admin cannot add sue to org1, because
the cred1 role for sue has an ancestor to org1 role. The org1
admin cannot change or attach sue to org1.

tower issue ansible#4198 and ansible#4197
fosterseth added a commit to fosterseth/awx that referenced this pull request Apr 2, 2020
@fosterseth
Allow orphaned user to be added to org
e1c2dc8 
Fixed bug where an org admin was not able to add
an orphaned user to the org, in the case where the
orphan had an ancestor role that matched one of the
roles for of the org admin.

scenario to fix -- sue is member of cred1, where cred1 is
part of org1. org1 admin cannot add sue to org1, because
the cred1 role for sue has an ancestor to org1 role. The org1
admin cannot change or attach sue to org1.

tower issue ansible#4198 and ansible#4197
fosterseth added a commit to fosterseth/awx that referenced this pull request Apr 2, 2020
@fosterseth
Allow orphaned user to be added to org
843c22c 
Fixed bug where an org admin was not able to add
an orphaned user to the org, in the case where the
orphan had an ancestor role that matched one of the
roles for of the org admin.

scenario to fix -- sue is member of cred1, where cred1 is
part of org1. org1 admin cannot add sue to org1, because
the cred1 role for sue has an ancestor to org1 role. The org1
admin cannot change or attach sue to org1.

tower issue ansible#4198 and ansible#4197
This was referenced Jan 21, 2022
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbradberry jbradberry jbradberry requested changes

@ryanpetrello ryanpetrello ryanpetrello approved these changes

@rooftopcellist rooftopcellist rooftopcellist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shanemcd @ryanpetrello @jbradberry @rooftopcellist