Bugfix - Slack notification with name and avatar #5125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
ryanpetrello
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
Thanks @gmarsay I'm able to reproduce what you're describing here, and your fix seems to help.
|
Build failed (gate pipeline). For information on how to proceed, see
|
|
regate |
|
Build failed (gate pipeline). For information on how to proceed, see
|
|
regate |
|
Build succeeded (gate pipeline).
|
AlanCoding
pushed a commit
to AlanCoding/awx
that referenced
this pull request
Jun 23, 2021
Disable edit fields for managed EE, except pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently, if color field isn't defined, the Slack integration will send notifications to Slack as the user "bot" with a generic avatar icon.
ISSUE TYPE
COMPONENT NAME
main/notifications/slack_backend.py
AWX VERSION
This bug is currently present on devel branch ans affect all version.