AceEditor - codemirror replacement #9281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
keithjgrant
force-pushed
the
8905-codemirror-replacement
branch
from
8203471
to
ec070c8
Compare
|
Build succeeded.
|
keithjgrant
requested review from
jakemcdermott and
marshmalien
and removed request for
jakemcdermott
|
Build succeeded.
|
| "ansi-to-html": "^0.6.11", | ||
| "axios": "^0.21.1", | ||
| "codemirror": "^5.47.0", |
|
Build succeeded.
|
keithjgrant
force-pushed
the
8905-codemirror-replacement
branch
from
9922fca
to
381f463
Compare
|
Build succeeded.
|
jakemcdermott
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
- Code lgtm.
- I lightly tested this, but focused mostly on the details component. There's a few things we're aiming to disable when in
readOnlymode which I discussed w/ @keithjgrant offline.
That said, we'll want several sets of eyes to take a look.
jakemcdermott
requested review from
jlmitch5,
mabashian,
AlexSCorey and
nixocio
|
@keithjgrant do you mind syncing with @one-t before code review is done to get a feel for the impact to the tests? Hopefully it's widespread (coverage), but easy to fix |
nixocio
approved these changes
Feb 23, 2021
keithjgrant
force-pushed
the
8905-codemirror-replacement
branch
from
68456be
to
a25081c
Compare
|
Build succeeded.
|
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
keithjgrant
force-pushed
the
8905-codemirror-replacement
branch
from
459bac6
to
6f7a717
Compare
|
Build succeeded.
|
* fix typing space character * hide cursor when editor doesn't have user focus * show help text any time editor is in focus * fix content shifting when help text appears/disappears * remove 80 character "print limit" line
|
Build failed.
|
|
Build failed.
|
|
Build succeeded.
|
|
Build failed.
|
|
Regate |
|
recheck |
|
Build succeeded.
|
|
Regate |
|
Build succeeded (gate pipeline).
|
nixocio
pushed a commit
to nixocio/awx
that referenced
this pull request
Mar 15, 2021
…acement
AceEditor - codemirror replacement
Reviewed-by: John Hill <johill@redhat.com>
https://github.com/unlikelyzero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Replaces CodeMirror component with AceEditor component
Addresses #8905, #8176, #8827
ISSUE TYPE
COMPONENT NAME
NOTES
A note about accessibility/keyboard navigation, since I do some unusual manipulation of
tabIndex: I based my approach on the way PF handles their CodeEditor component (https://patternfly-react.surge.sh/components/code-editor).When navigating via keyboard, the editor is first highlighted in a non-editable mode. The user can continue to tab through the page to the next input, or they may press Enter to begin editing the code input. While editing, tabs are typed into the input area as normal input. Pressing escape (or Shift-Tab) will leave the editable mode, returning to the "selected" mode, where the user may continue to tab through the page normally.
Mouse navigation works as normal: click the editor to place a cursor and begin typing.