Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AceEditor - codemirror replacement #9281

Merged
merged 19 commits into from
Mar 12, 2021
Merged

AceEditor - codemirror replacement #9281

merged 19 commits into from
Mar 12, 2021

Commits on Mar 9, 2021

  1. Ace editor POC

    @keithjgrant
    keithjgrant committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    1afdd7a View commit details
    Browse the repository at this point in the history

  2. add code editor focus/blur keyboard controls

    @keithjgrant
    keithjgrant committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    4e9c6a9 View commit details
    Browse the repository at this point in the history

  3. styling Ace CodeEditor

    @keithjgrant
    keithjgrant committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    5c38011 View commit details
    Browse the repository at this point in the history

  4. rename CodeMirror to CodeEditor

    @keithjgrant
    keithjgrant committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    070c67f View commit details
    Browse the repository at this point in the history

  5. add keyboard navigation help text to CodeEditor

    @keithjgrant
    keithjgrant committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    19f4de0 View commit details
    Browse the repository at this point in the history

  6. remove codemirror dependencies

    @keithjgrant
    keithjgrant committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    411d692 View commit details
    Browse the repository at this point in the history

  7. disable interactive elements of CodeEditor in readOnly mode

    @keithjgrant
    keithjgrant committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    221021a View commit details
    Browse the repository at this point in the history

  8. add AceEditor to changelog

    @keithjgrant
    keithjgrant committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    2995cde View commit details
    Browse the repository at this point in the history

  9. CodeEditor: fix hidden error message

    @keithjgrant
    keithjgrant committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    c975f65 View commit details
    Browse the repository at this point in the history

  10. add value assertions to code editor tests

    @keithjgrant
    keithjgrant committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    143d41f View commit details
    Browse the repository at this point in the history

  11. add more code editor tests

    @keithjgrant
    keithjgrant committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    4e55c98 View commit details
    Browse the repository at this point in the history

  12. add tests ensuring forms pass correct value to CodeEditor fields

    @keithjgrant
    keithjgrant committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    6b2cee2 View commit details
    Browse the repository at this point in the history

  13. don't show CodeEditor control help text in readonly mode

    @keithjgrant
    keithjgrant committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    c2a2bf3 View commit details
    Browse the repository at this point in the history

  14. CodeEditor: don't type newline when pressing enter to start edit mode

    @keithjgrant
    keithjgrant committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    0b57522 View commit details
    Browse the repository at this point in the history

  15. hide CodeEditor touch controls menu

    @keithjgrant
    keithjgrant committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    6f7a717 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. CodeEditor bugfixes 

    * fix typing space character
* hide cursor when editor doesn't have user focus
* show help text any time editor is in focus
* fix content shifting when help text appears/disappears
* remove 80 character "print limit" line
    @keithjgrant
    keithjgrant committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    4ea7c8a View commit details
    Browse the repository at this point in the history

  2. fix lint error

    @keithjgrant
    keithjgrant committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    726b5dd View commit details
    Browse the repository at this point in the history

  3. fix CodeEditor tests

    @keithjgrant
    keithjgrant committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    05f9303 View commit details
    Browse the repository at this point in the history

  4. debounce CodeEditor onChange for performance improvement

    @keithjgrant
    keithjgrant committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    c90dfbb View commit details
    Browse the repository at this point in the history