Add docker molecule driver #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziegenberg
force-pushed
the
add-docker-driver
branch
from
d31edaa
to
74ac800
Compare
|
hi @ssbarnea! Could you approve running the ci workflow? |
ssbarnea
reviewed
Mar 1, 2022
As this image is superseding the ansible toolset image, it should aim at feature parity with its precursor. This change adds the molecule docker driver, and its necessary dependencies. This also includes the community.docker ansible collection, as written in the molecule-docker README. See: ansible#20 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
force-pushed
the
add-docker-driver
branch
from
ce98cab
to
f31c25d
Compare
ssbarnea
approved these changes
Mar 9, 2022
|
I think I made a small mistake. |
ziegenberg
added a commit
to ziegenberg/creator-ee
that referenced
this pull request
Mar 16, 2022
In ansible#22 and ansible#23 the podman and docker molecule drivers were added but the respective binaries are still missing. This commit adds the neccesarry dependencies to the execution enviroments bindep.txt. This commit also adds some cli commands to check we do not remove them inadvertantly and output some helpful version information at build time. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
added a commit
to ziegenberg/creator-ee
that referenced
this pull request
Mar 16, 2022
In ansible#22 and ansible#23 the podman and docker molecule drivers were added, but the respective binaries are still missing. This commit adds the necesarry dependencies to the execution enviroments bindep.txt. This commit also adds some CLI commands to check we do not remove them inadvertently and output some helpful version information at build time. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
added a commit
to ziegenberg/creator-ee
that referenced
this pull request
Mar 16, 2022
In ansible#22 and ansible#23 the podman and docker molecule drivers were added, but the respective binaries are still missing. This commit adds the necesarry dependencies to the execution enviroments bindep.txt. This commit also adds some CLI commands to check we do not remove them inadvertently and output some helpful version information at build time. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
added a commit
to ziegenberg/creator-ee
that referenced
this pull request
Mar 16, 2022
In ansible#22 and ansible#23 the podman and docker molecule drivers were added, but the respective binaries are still missing. This commit adds the necesarry dependencies to the execution enviroments bindep.txt. This commit also adds some CLI commands to check we do not remove them inadvertently and output some helpful version information at build time. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
added a commit
to ziegenberg/creator-ee
that referenced
this pull request
Mar 17, 2022
In ansible#22 and ansible#23 the podman and docker molecule drivers were added, but the respective binaries are still missing. This commit adds the necesarry dependencies to the execution enviroments bindep.txt. This commit also adds some CLI commands to check we do not remove them inadvertently and output some helpful version information at build time. There is also a workaround to make installing podman and docker simultaneously possible. This is due to a conflict between the packaged version of runc in the containerd.io package from Docker and the CentOS 8 Stream native version packaged for Podman and Skopeo. This can be changed once docker/containerd-packaging#231 is merged and available upstream via the Docker repository. Cudos for the workaround: https://faun.pub/how-to-install-simultaneously-docker-and-podman-on-rhel-8-centos-8-cb67412f321e Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
added a commit
to ziegenberg/creator-ee
that referenced
this pull request
Mar 17, 2022
In ansible#22 and ansible#23 the podman and docker molecule drivers were added, but the respective binaries are still missing. This commit adds the necesarry dependencies to the execution enviroments bindep.txt. This commit also adds some CLI commands to check we do not remove them inadvertently and output some helpful version information at build time. There is also a workaround to make installing podman and docker simultaneously possible. This is due to a conflict between the packaged version of runc in the containerd.io package from Docker and the CentOS 8 Stream native version packaged for Podman and Skopeo. This can be changed once docker/containerd-packaging#231 is merged and available upstream via the Docker repository. Cudos for the workaround: https://faun.pub/how-to-install-simultaneously-docker-and-podman-on-rhel-8-centos-8-cb67412f321e Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this image is superseding the ansible toolset image, it should aim at feature parity with its precursor.
This change adds the molecule docker driver, and its necessary dependencies. This also includes the
community.dockeransible collection, as written in the molecule-docker README.Partly fixes: #20