Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce number of layers #55

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Reduce number of layers #55

merged 3 commits into from
Apr 22, 2022

Conversation

ziegenberg
Copy link
Contributor

@ziegenberg ziegenberg commented Apr 19, 2022 •
edited

Not really shaving off much of the image size, but at least reducing the number of layers.

@ziegenberg ziegenberg requested a review from a team as a code owner April 19, 2022 16:36
@ssbarnea ssbarnea added the bug Something isn't working label Apr 22, 2022
@ziegenberg
Copy link
Contributor Author

fixing the linting...

@ssbarnea ssbarnea changed the title reduce number of layers Reduce number of layers Apr 22, 2022
@ziegenberg
Copy link
Contributor Author

tox -e lint removes a new line from Containerfile and tox -e build adds just that new line to Containerfile. 🤦🏻‍♂️

@ssbarnea
Copy link
Member

Ideally we should prevent it from adding the extra line but if not possible we can add this file to the exclude list of the hook that gets upset.

@ziegenberg ziegenberg force-pushed the reduce-layers-1 branch 2 times, most recently from 42c4db3 to 0797749 Compare April 22, 2022 11:54
@ziegenberg
reduce number of layers
6dfb858 
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg
fix linting
b5dfd34 
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg
fix yaml multiline block scalars and use correct block chomping
eec5c17 
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ssbarnea ssbarnea merged commit 3d3a184 into ansible:main Apr 22, 2022
@ziegenberg ziegenberg deleted the reduce-layers-1 branch April 22, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@ganeshrn ganeshrn Awaiting requested review from ganeshrn ganeshrn is a code owner automatically assigned from ansible/devtools

@cidrblock cidrblock Awaiting requested review from cidrblock cidrblock is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ziegenberg @ssbarnea