Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content origin temp var should be the same for both scenarios #138

Merged

Conversation

rooftopcellist
Copy link
Member

SUMMARY

If the pulp_settings.content_origin is set by the user, we should set the temp content_orgin var so that it is used in the token_server_dict var, otherwise if the user sets this variable it will fail on the task that sets that dict.

Without this, the following error will be seen:

TASK [Set token_server and other container default settings] ******************************** 
fatal: [localhost]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'content_origin' is undefined\n\nThe error appears to be in '/opt/ansible/roles/galaxy-config/tasks/combine_galaxy_settings.yml': line 41, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Set token_server and other container default settings\n  ^ here\n"}

If the user does not set pulp_settings.content_origin, content_origin is set in the get_node_ip.yml task.

ADDITIONAL INFORMATION

This is follow-up for https://github.com/ansible/galaxy-operator/pull/137/files, which introduced this regression.

- If the pulp_settings.content_origin is set by the user, we should set
  the temp content_orgin var so that it is used in the
  token_server_dict var, otherwise if the user sets this variable it
  will fail on the task that sets that dict.
@rooftopcellist rooftopcellist merged commit 5eef56d into ansible:main Jul 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant