-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker entrypoint errors introduced by #715 #721
Fix docker entrypoint errors introduced by #715 #721
Conversation
Issue: AAH-486
This looks good to me, going to check out the fork and verify it works as expected. |
Works for me :) |
docker/entrypoint.sh
Outdated
protocol="rediss://" | ||
else | ||
protocol="redis://" | ||
fi | ||
|
||
if [[ -z "$PULP_REDIS_PASSWORD" ]]; then | ||
if [[ ${PULP_REDIS_PASSWORD:-nopassword} = "nopassword" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if [[ ${PULP_REDIS_PASSWORD:-nopassword} = "nopassword" ]]; then | |
if [[ -z "${PULP_REDIS_PASSWORD:-}" ]]; then |
# settings for RQ in pulpcore/rqconfig.py | ||
p_redis_host="${PULP_REDIS_HOST:-localhost}" | ||
p_redis_port="${PULP_REDIS_PORT:-6379}" | ||
redis_connection_hack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can move it below wait-for-tcp to avoid variable assignments
Issue: AAH-486
Issue: AAH-486
59d2218
to
03d45f8
Compare
Issue: AAH-486