Fix packaging #2381
Merged
Fix packaging #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes hacks from setup.py and adds extra tests that should prevent future regressions. The previous workaround was broken as tox was unable to run twice on the same environment. The assumption that newer setuptools was preventing installation only during install was wrong, the reality was that newer version broke packaging completely. Fixes: #2379 Signed-off-by: Bogdan Ristea <Bogdan Ristea bogdan.ristea@gmail.com>
Signed-off-by: Bogdan Ristea <Bogdan Ristea bogdan.ristea@gmail.com>
ssbarnea
requested changes
Oct 20, 2019
ssbarnea
approved these changes
Oct 20, 2019
sio
pushed a commit
to sio/molecule
that referenced
this pull request
Feb 18, 2020
Removes hacks from setup.py and adds extra tests that should prevent future regressions. The previous workaround was broken as tox was unable to run twice on the same environment. The assumption that newer setuptools was preventing installation only during install was wrong, the reality was that newer version broke packaging completely. Fixes: ansible#2379 Signed-off-by: Bogdan Ristea <Bogdan Ristea bogdan.ristea@gmail.com>
Oloremo
pushed a commit
to Oloremo/molecule
that referenced
this pull request
May 4, 2020
Removes hacks from setup.py and adds extra tests that should prevent future regressions. The previous workaround was broken as tox was unable to run twice on the same environment. The assumption that newer setuptools was preventing installation only during install was wrong, the reality was that newer version broke packaging completely. Fixes: ansible#2379 Signed-off-by: Bogdan Ristea <Bogdan Ristea bogdan.ristea@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes hacks from setup.py and adds extra tests that should
prevent future regressions.
The previous workaround was broken as tox was unable to run twice
on the same environment. The assumption that newer setuptools
was preventing installation only during install was wrong, the
reality was that newer version broke packaging completely.
Fixes: #2379
Signed-off-by: Bogdan Ristea <Bogdan Ristea bogdan.ristea@gmail.com>
Please include details of what it is, how to use it, how it's been tested
Please include an entry in the CHANGELOG.md if the change will impact users.
PR Type