Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(#3299): avoid to use dash for role name #3300

Merged
merged 2 commits into from
Nov 14, 2021
Merged

docs(#3299): avoid to use dash for role name #3300

merged 2 commits into from
Nov 14, 2021

Conversation

xhiroga
Copy link
Contributor

@xhiroga xhiroga commented Nov 14, 2021 •
edited
Loading

Fix document to make getting started works

PR Type

  • Docs Pull Request

Motivation

#3299

@tadeboro tadeboro linked an issue Nov 14, 2021 that may be closed by this pull request
docs: Ansible Galaxy does not allow using dash in role name, but tutorial use dash #3299
Closed
@tadeboro
Copy link
Contributor

Thank you, @xhiroga, for your contribution. I am merging this since the only test that failed is known to have problems (#3291).

@tadeboro tadeboro merged commit 8b0df90 into ansible:main Nov 14, 2021
@xhiroga xhiroga deleted the docs/getting-started-with-no-dash-role-name branch November 14, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeboro tadeboro tadeboro approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea

@webknjaz webknjaz Awaiting requested review from webknjaz

Assignees
No one assigned
Labels
bug docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: Ansible Galaxy does not allow using dash in role name, but tutorial use dash
3 participants
@xhiroga @tadeboro @webknjaz