Allow mixing links and inventory variables #3501
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Previous logic allowed either link or direct specification in molecule.yml, while it's very convenient to link to group_vars containing some common values and set other (specific to molecule test) as host_vars.
cinek810
force-pushed
the
mix_links_and_inv
branch
from
c958874
to
48f0c42
Compare
|
Hello. It looks amazing and it fixing one of weak points of Molecule! I'm very excited to see it fixed. Can you, please, add a few tests? It can quickly become messy (there is a lot of corner cases), and having some tests will helps to cover them all. |
|
Sure. Can you point me to an example commit I can follow preparing the tests? |
ssbarnea
requested review from
ziegenberg,
ganeshrn and
cidrblock
and removed request for
a team
|
Can someone step in here to add some tests, without any tests I will likely close it. |
|
If someone can point me to a commit (or external link) where similar tests where added I'll work on that. I just don't have relevant experience. |
|
Can you point me to a minimal scenario that was failing before this change and that is working after it? ... that would be a test by itself. |
|
Closing this due to lack of updates. |
|
Hello! Are there any changes about the pull request? |
Previous logic allowed either link or direct specification in molecule.yml, while it's very convenient to link to group_vars containing some common values and set other (specific to molecule test) as host_vars.
Fixes: #2759