fix tests for commands molecule init role and molecule init scenario
#3924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziegenberg
requested review from
greg-hellings,
sky-joker,
ssbarnea,
cidrblock and
shatakshiiii
and removed request for
a team
Currently the tests fail for `test_command_init_role` and `test_command_init_scneario`. The tests execute `ansible-lint` on the newly-created roles and the linter recently got more restrictive, so we now have to adapt.
|
And @ssbarnea fixed the remaining issue in ansible/ansible-compat#284 :) |
|
This change is now included in PR #3904, so closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the tests fail for
test_command_init_roleandtest_command_init_scneario. The tests executeansible-linton the newly-created roles and the linter recently got more restrictive, so we now have to adapt.There are still two failures with Python 3.11 and ansible-core devel.
ansible-compatcallsansible-galaxy collection list --format=jsoninternally (https://github.com/ansible/ansible-compat/blob/d30965cd023b4116f6e959ace0e4dbf219677952/src/ansible_compat/runtime.py#LL235C20-L235C20) and due to some unknown reason it is executed with elevated verbosity producing broken json output. The output begins with: