-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a quiet option to the list command #75
Conversation
Maybe @abrown-sg has more insight on this. |
The extra line is completely unnecessary. I probably threw it in to make things stand out more visually, but it's problematic when trying to parse the output of the command. I think it's fine to remove it rather than have an if statement for it. There's probably a few other commands that have this behavior that could also be cleaned up. Not sure why list has --platform and --provider, those should be removed. Should we consider naming the flag for formatting the output of commands to be machine readable something other than -q? To me, "quiet" generally indicates there will be no output. Not sure if there's an existing convention for that. |
Ok, I'm going to fix the empty line and adjust the unused arguments. Regarding the
But you're right, for
I'm totally fine with replacing the Maybe that could be controlled by the verbosity argument? We could adopt this convention for all our commands: |
* Add .idea directory * Sort the file using ``sort -f .gitignore``
The list command did not use the ``platform`` and ``provider`` arguments, therefore they got removed. There for no need of printing an empty line before displaying the list of available platforms, therefore it got removed as well.
Traditionally:
However:
|
I like that explanation! 👍 Just I think 7 levels of verbosity might be a bit excessive ( Action items:
|
Machine readable outputs will be triggered by the use of the ``-m`` switch instead of ``-q``.
👍 |
Add a quiet option to the list command
The use case behind it is to be able to run the tests over all the available
platforms in one line:
This PR also raised 2 questions:
[--platform=<platform>] [--provider=<provider>]
options?