Support ansible v28+ #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 190
💛 - Coveralls |
For ansible 2.8+ need to clear command line args Because ansible is creating an immutable global Singleton context with the results of command line parsing. So you have to "reset" that first, before doing it again in a test. Do this in a try/except block to keep backwards compatablity make version comparison more flexible to handle 2.8 after release Refactor has_ansible_version use bugfix, test was right all along
|
@jlaska is it possible to cut a new release of pytest-ansible? I'm using Ansible 2.8 and without this change I can't use pytest-ansible. If there's anything I can do to help, please let me know. |
|
@edwinpjacques This code is now available in pytest-ansible-2.1.1. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@abadger trying it out here...