Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for Controlsvc #827

Merged
merged 11 commits into from
Sep 27, 2023
Merged

Add unit tests for Controlsvc #827

merged 11 commits into from
Sep 27, 2023

Conversation

resoluteCoder
Copy link
Contributor

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AaronH88
Copy link
Contributor

Overall very good! Few small comments and one structural question, but this is great work!

@resoluteCoder resoluteCoder changed the title Controlsvc file Add unit tests for Controlsvc Sep 20, 2023
@resoluteCoder resoluteCoder marked this pull request as ready for review September 20, 2023 19:08
@resoluteCoder resoluteCoder force-pushed the controlsvc-file branch 3 times, most recently from 5384a77 to a846116 Compare September 26, 2023 17:11
@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Merging #827 (17d4eb6) into devel (2e7a9ab) will increase coverage by 3.21%.
Report is 1 commits behind head on devel.
The diff coverage is 71.75%.

@@            Coverage Diff             @@
##            devel     #827      +/-   ##
==========================================
+ Coverage   30.70%   33.92%   +3.21%     
==========================================
  Files          44       44              
  Lines        8530     8555      +25     
==========================================
+ Hits         2619     2902     +283     
+ Misses       5671     5407     -264     
- Partials      240      246       +6
Files Coverage Δ
pkg/controlsvc/ping.go 13.88% <0.00%> (+13.88%) ⬆️
pkg/controlsvc/status.go 0.00% <0.00%> (ø)
pkg/controlsvc/traceroute.go 0.00% <0.00%> (ø)
pkg/controlsvc/connect.go 0.00% <0.00%> (ø)
pkg/workceptor/controlsvc.go 0.00% <0.00%> (ø)
pkg/controlsvc/reload.go 69.60% <50.00%> (+18.39%) ⬆️
pkg/controlsvc/controlsvc.go 74.63% <77.11%> (+73.37%) ⬆️

... and 3 files with indirect coverage changes

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
2.6% 2.6% Duplication

AaronH88
AaronH88 reviewed Sep 27, 2023
View reviewed changes
Makefile Show resolved Hide resolved
AaronH88
AaronH88 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit 7aee413 into ansible:devel Sep 27, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanemcd shanemcd shanemcd left review comments

@AaronH88 AaronH88 AaronH88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@resoluteCoder @AaronH88 @shanemcd