This repository has been archived by the owner on Sep 16, 2020. It is now read-only.
Add shortcut fields for credential inputs #550
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect #356
This was not at all as easy as I had imagined, but I am pretty sure this works. As a general method, it also probably could some some other yet-undiscovered bugs as data is modified in special-cases.
I worry that this isn't quite the right way to go. It doesn't allow specifying multi-line inputs of arbitrary fields, which could matter for custom credentials. We could do this with click with a single new field that allows arbitrary input like the
--query
parameter. Say:But this raises additional question about how to determine data type. We could get the data type from the credential type input schema. I don't know if there would be much value in doing that, but it could crumble if users specified a boolean or integer.