This repository has been archived by the owner on Sep 16, 2020. It is now read-only.
Improve error handling for users using the schema command #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanCoding
force-pushed
the
schema_error_handling
branch
from
d1bed19
to
fb1772b
Compare
beeankha
reviewed
Mar 12, 2020
| ujt_ambiguity_msg = ( | ||
| 'You should provide exactly one of the attributes' | ||
| ' job_template, project, workflow, inventory_source, or unified_job_template.' | ||
| ) |
kedark3
reviewed
Mar 12, 2020
| @@ -45,16 +45,19 @@ def __init__(self, data, wfjt, include_id=False): | |||
| else: | |||
| node_attrs[fd] = data[fd] | |||
| node_attrs['workflow_job_template'] = wfjt | |||
| ujt_ambiguity_msg = ( | |||
| 'You should provide exactly one of the attributes' | |||
| ' job_template, project, workflow, inventory_source, or unified_job_template.' | |||
There was a problem hiding this comment.
👍 for this clear message. Although I am not familiar with unified_job_template
beeankha
approved these changes
Mar 12, 2020
kedark3
reviewed
Mar 12, 2020
| @@ -127,6 +127,16 @@ network with a tower-cli command after the constituent resources like | |||
| the job templates and projects were created by preceding tower-cli | |||
| commands. | |||
|
|
|||
| Workflows Inside Workflows | |||
There was a problem hiding this comment.
This is good. How about adding workflow above as well in the example https://github.com/ansible/tower-cli/pull/750/files#diff-e888d13496218a3618bbee8be0d2a7d1R114-R124 ? I see example already shows jt, project, inv_source, so we can add workflow there and make it a complete example. Just a suggestion.
There was a problem hiding this comment.
I hope you don't mind that I don't do that out of sheer laziness. I know that I've tested the content here is functional. The implication is that you can combine them all together, but we just don't want poke this library any more than we have to.
kedark3
approved these changes
Mar 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the server stopped verifying that
unified_job_templatehas a non-null value because of the additional of approval nodes.This has a consequence for function of the schema command, since it was never documented how to use workflows-in-workflows. It would silently finish with null nodes, which is a sideways state.