Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling Lightspeed in settings does not disable features #859

Closed
timfallmk opened this issue Apr 17, 2023 · 16 comments · Fixed by #911
Closed

Disabling Lightspeed in settings does not disable features #859

timfallmk opened this issue Apr 17, 2023 · 16 comments · Fixed by #911
Assignees
Labels
bug Something isn't working

Comments

@timfallmk
Copy link

timfallmk commented Apr 17, 2023

Summary

With the introduction of new Lightspeed integration in 2.0 I'm now getting bugged to "log in to ansible lightspeed to use ansible" on every open window. I have the "Lightspeed" enable option unchecked in the settings.
image
image

There may be other parts of Lightspeed that are not being disabled when the user explicitly does not enable them.

Extension version

v2.0.58

VS Code version

1.77.3

Ansible Version

ansible [core 2.14.4]
  config file = /Users/tfall/Code/stand-configuration/ansible.cfg
  configured module search path = ['/Users/tfall/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /opt/homebrew/Cellar/ansible/7.4.0/libexec/lib/python3.11/site-packages/ansible
  ansible collection location = /Users/tfall/.ansible/collections:/usr/share/ansible/collections
  executable location = /opt/homebrew/bin/ansible
  python version = 3.11.3 (main, Apr  7 2023, 20:13:31) [Clang 14.0.0 (clang-1400.0.29.202)] (/opt/homebrew/Cellar/ansible/7.4.0/libexec/bin/python3.11)
  jinja version = 3.1.2
  libyaml = True

OS / Environment

macOS Ventura 13.3.1
ansible-lint 6.14.6 using ansible 2.14.4

Relevant log output

No response

@timfallmk timfallmk added bug Something isn't working new labels Apr 17, 2023
@rothfralick
Copy link

Same here. Very annoying.
Ansible extension v2.0.58
VSCode 1.77.3
Windows 11

@Zombiefleischer
Copy link

Also autocompletion is not working with this new version
Ansible extension v2.0.58
VSCode 1.77.3
Linux Debian

@harwinds
Copy link

Same here, please give me the option to disable it. Get rid of the (1) indicator.

@ganeshrn
Copy link
Member

@timfallmk Thanks for raising the issue, we will work on the fix.

@Zombiefleischer

Also autocompletion is not working with this new version

Autocompletion should work irrespective of Lightspeed is enabled or disabled.
Is it possible for you to share a screen recording?
Also the debug logs, you can refer this to get the debug logs

@Zombiefleischer
Copy link

I went back to v1.2.44 for the time being and to get the screen recording I switched back to the latest version (v2.0.58) and it automagically fixed itself. I don't know what went wrong, but it works fine now. Sorry for the inconvenience.

@lcrownover
Copy link

I assume based on response that this is a known issue that will be resolved, but I figured I'd just add to the dogpile.

That (1) is annoying!

@rubin55
Copy link

rubin55 commented Apr 21, 2023

The message is:

Sign in with Ansible Lightspeed to use Ansible(1)

Question: Is the intention of this to communicate the Ansible extension won't work unless you log in using Ansible Lightspeed?

@ganeshrn
Copy link
Member

ganeshrn commented Apr 24, 2023

@rubin55 Ansible extension will continue to work irrespective of user has logged in to the Ansible Lightspeed service. I agree the message is misleading and we can change it.

Ansible Lightspeed is currently in closed beta and provides AI based code suggestion and for this feature to work users will have to log in to the Lightspeed service.

@priyamsahoo priyamsahoo removed the new label Apr 26, 2023
@safderali5
Copy link

very annoying and no way to disable this :-(

@harwinds
Copy link

I actually unchecked the Accounts from the side bar to get rid of the annoying (1) for the Ansible extension.

image

@MrSteve81
Copy link

Also autocompletion is not working with this new version Ansible extension v2.0.58 VSCode 1.77.3 Linux Debian

I can also confirm when i am on v2.0.58 the auto complete for modules does not work
image
but when i switch back to Ansible
v1.2.44 it works

@ganeshrn
Copy link
Member

ganeshrn commented May 5, 2023

The notification disable issue is fixed by PR #877 and will be available in the next minor version release of the extension.
Unfortunately there is no direct way provided by VSCode API's to change the sign in message as reported in the comment #859 (comment). We have raised a new issue #879 to track it and it might take some time to fix it.

@ganeshrn
Copy link
Member

ganeshrn commented May 5, 2023

@MrSteve81 The autocompletion feature should work irrespective of if you sign to Lightspeed service or not. Please refer to my comment #859 (comment). After updating the version try reloading VSCode. It might be an intermittent issue as reported here #859 (comment)

@dszryan
Copy link

dszryan commented May 10, 2023

"ansible.lightspeed.URL": "",

seemed to have reduced the annoyance

@huyz
Copy link

huyz commented May 11, 2023

"ansible.lightspeed.URL": "",

hehe that's the kind of workaround that will make it harder to adopt this new feature when it is actually available—perhaps devs will learn from that for next time.

@mousedownmike
Copy link

Setting "ansible.lightspeed.URL": "", didn't remove the Sign In badge for me on Linux and MacOS. It looked like it did when I first made the change, but the badge came back after subsequent reloads.

ganeshrn added a commit to ganeshrn/vscode-ansible that referenced this issue Jun 5, 2023
Fixes ansible#859

In addition to PR ansible#877
update the logic to initialize the Lightspeed authentication provider
only after the Lightspeed setting is enabled.
ganeshrn added a commit that referenced this issue Jun 5, 2023
…911)

* Fix notification for lightspeed login

Fixes #859

In addition to PR #877
update the logic to initialize the Lightspeed authentication provider
only after the Lightspeed setting is enabled.

* remove reload logis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.