Add logic for conditional Authentication Provider registration #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR is made to this branch so that we can make a PR from the repository itself in order to run the lightspeed e2e tests on the PR.
ganeshrn
approved these changes
May 5, 2023
github-actions bot
pushed a commit
that referenced
this pull request
May 18, 2023
## v2.1 ### Minor Changes - Easy discovery of Python interpreter and Ansible executables (#871) @priyamsahoo ### Bugfixes - Add information message for inline suggestion trigger command (#896) @ganeshrn - Update status-bar items (#891) @priyamsahoo - Update inline suggestion trigger condition (#892) @ganeshrn - Add ability to select and set cursor on vars (#883) @priyamsahoo - Add logic for conditional Authentication Provider registration (#877) @ganeshrn - Fix regex to match trigger for lightspeed suggestion (#875) @ganeshrn - Update dependencies (#872) @ssbarnea
Merged
ansibot
added a commit
that referenced
this pull request
May 18, 2023
## v2.1 ### Minor Changes - Easy discovery of Python interpreter and Ansible executables (#871) @priyamsahoo ### Bugfixes - Add information message for inline suggestion trigger command (#896) @ganeshrn - Update status-bar items (#891) @priyamsahoo - Update inline suggestion trigger condition (#892) @ganeshrn - Add ability to select and set cursor on vars (#883) @priyamsahoo - Add logic for conditional Authentication Provider registration (#877) @ganeshrn - Fix regex to match trigger for lightspeed suggestion (#875) @ganeshrn - Update dependencies (#872) @ssbarnea Co-authored-by: Ansible DevTools <ansible-devtools@redhat.com>
ganeshrn
added a commit
to ganeshrn/vscode-ansible
that referenced
this pull request
Jun 5, 2023
Fixes ansible#859 In addition to PR ansible#877 update the logic to initialize the Lightspeed authentication provider only after the Lightspeed setting is enabled.
ganeshrn
added a commit
that referenced
this pull request
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR handles the case where users won't be able to log in unless they enable lightspeed services from the settings.
This removes the notification from the accounts icon in vscode when the settings are disabled.
Related to: #859