-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge summaries API into generations API for WCA support #1320
Merged
TamiTakamiya
merged 1 commit into
main
from
TamiTakamiya/playbook-generation-api-change-for-wca
May 23, 2024
Merged
Merge summaries API into generations API for WCA support #1320
TamiTakamiya
merged 1 commit into
main
from
TamiTakamiya/playbook-generation-api-change-for-wca
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goneri
reviewed
May 16, 2024
goneri
reviewed
May 16, 2024
TamiTakamiya
force-pushed
the
TamiTakamiya/playbook-generation-api-change-for-wca
branch
from
May 17, 2024 13:43
64d8d99
to
6c68c4b
Compare
@goneri Would you take a look at this PR again? Thank you. |
TamiTakamiya
force-pushed
the
TamiTakamiya/playbook-generation-api-change-for-wca
branch
from
May 22, 2024 20:33
1b08cec
to
bd7ddb3
Compare
TamiTakamiya
force-pushed
the
TamiTakamiya/playbook-generation-api-change-for-wca
branch
from
May 23, 2024 11:52
bd7ddb3
to
af66602
Compare
goneri
approved these changes
May 23, 2024
TamiTakamiya
deleted the
TamiTakamiya/playbook-generation-api-change-for-wca
branch
May 23, 2024 14:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge summaries API into generations API to be more consistent with corresponding WCA API.