New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inline encryption of multiline strings #337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you would not mind, next time you find such a bug file a ticket before starting to work on fixing it and mention that you will try to fix it yourself. That is better for several reasons: letting others be aware of existing bug and also avoiding having two working on fixing the same bug.
I mentioned that because your PR went in while I was running the release pipeline. If I knew about that one hour earlier I could have delayed it and include the fix in 0.7.0 release.
PS. I am currently testing the code.
@jeinwag Can you please mention on clear operation where this failed before your patch and that started working correctly after your patch. Based on my testing I seen that round-trip operation worked all time, even if the original block was a multiline one, with |
@ssbarnea sorry, I should have clarified. Running the following example with the value of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I understand it better I will approve it but not merge it yet, mainly because I want to merge first the change that adds extra testing.
With extra testing it should become quite easy to add a test for this bugfix, so we would prevent regressions.
Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>
Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com> Co-authored-by: Sorin Sbarnea <ssbarnea@redhat.com> Co-authored-by: Sorin Sbarnea <sorin.sbarnea@gmail.com>
Bumps [ansible-compat](https://github.com/ansible-community/ansible-compat) from 2.0.4 to 2.1.0. - [Release notes](https://github.com/ansible-community/ansible-compat/releases) - [Commits](ansible/ansible-compat@v2.0.4...v2.1.0) --- updated-dependencies: - dependency-name: ansible-compat dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
I noticed that the inline encryption of multiline strings does not give the expected results.
This PR fixes the issue and implements proper handling of the different types of multiline blocks in YAML.