Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightspeed UI feedback and sentiment #924

Merged
merged 31 commits into from
Jun 21, 2023
Merged

Lightspeed UI feedback and sentiment #924

merged 31 commits into from
Jun 21, 2023

Conversation

ganeshrn
Copy link
Member

@ganeshrn ganeshrn commented Jun 19, 2023 •
edited
Loading

  • Add Ansible lightspeed feedback view (side panel) and webview (in editor tab) to get user feedback
  • Adds sentiment ratings and comment description box
  • For more feedback adds a drop down for Bug report, Feature request and Suggestion Improvements
  • Update feedback API to throw an user error when user in not logged in.
feedback_1 feedback_2 feedback_3 feedback_4

@ganeshrn ganeshrn requested a review from a team as a code owner June 19, 2023 10:29
@ganeshrn ganeshrn marked this pull request as draft June 19, 2023 10:31
@ganeshrn ganeshrn added feature New feature or request enhancement labels Jun 19, 2023
pre-commit-ci bot and others added 16 commits June 19, 2023 11:13
@pre-commit-ci
chore: auto fixes from pre-commit.com hooks
0dc7b6b 
for more information, see https://pre-commit.ci
@pre-commit-ci @audgirka
chore: auto fixes from pre-commit.com hooks
6cfc59e 
for more information, see https://pre-commit.ci
@audgirka
CSS styles are now working
2f623df
@audgirka
Update styles
1930d71
@audgirka
Update webview style and appearance
5340098
@pre-commit-ci
chore: auto fixes from pre-commit.com hooks
6acfef6 
for more information, see https://pre-commit.ci
@ganeshrn
Remove file media/codicon.css as it is not required
ea020bf
@ganeshrn
more changes
b05f34c
@ganeshrn
Fix review comments
54f1c7a
@audgirka
UI update for sentiment selection
5b0eb12
@audgirka
Rebase
69009fa
@ganeshrn
More fixes and webview addition
4ee15eb
@ganeshrn
add deleted file
ab201e6
@ganeshrn
remove hook id
eff9bc5
@pre-commit-ci
chore: auto fixes from pre-commit.com hooks
18487a6 
for more information, see https://pre-commit.ci
@ganeshrn
Add event listener for feedback and send to lightspeed service
6f68899
@ganeshrn ganeshrn marked this pull request as ready for review June 20, 2023 03:29
@ganeshrn ganeshrn mentioned this pull request Jun 20, 2023
Closed
@ganeshrn ganeshrn mentioned this pull request Jun 20, 2023
Merged
audgirka
audgirka approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@audgirka audgirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the UI tests are failing and checking the same with vscode-extension-tester team

@ganeshrn ganeshrn merged commit fdfef37 into ansible:main Jun 21, 2023
github-actions bot pushed a commit that referenced this pull request Jun 21, 2023
@ansibuddy
Release v2.4
4c6521d 
## v2.4

### Minor Changes

- Lightspeed UI feedback and sentiment (#924) @ganeshrn

### Bugfixes

- Update readme with lightspeed section (#926) @ganeshrn
@ansibot ansibot mentioned this pull request Jun 21, 2023
Merged
ganeshrn pushed a commit that referenced this pull request Jun 21, 2023
@ansibot @ansibuddy
Release v2.4 (#928)
208519d 
## v2.4

### Minor Changes

- Lightspeed UI feedback and sentiment (#924) @ganeshrn

### Bugfixes

- Update readme with lightspeed section (#926) @ganeshrn

Co-authored-by: Ansible DevTools <ansible-devtools@redhat.com>
github-actions bot pushed a commit that referenced this pull request Jul 28, 2023
@ansibuddy
Release v2.5
27e9dec 
## v2.5

### Minor Changes

- Lightspeed UI feedback and sentiment (#924) @ganeshrn

### Bugfixes

- Update readme with lightspeed section (#926) @ganeshrn
@ansibot ansibot mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottharwell scottharwell scottharwell left review comments

@audgirka audgirka audgirka approved these changes

@priyamsahoo priyamsahoo priyamsahoo approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea is a code owner automatically assigned from ansible/devtools

@Ruchip16 Ruchip16 Awaiting requested review from Ruchip16 Ruchip16 is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
enhancement feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ganeshrn @scottharwell @audgirka @priyamsahoo