Revise teardown strategy to handle 200+ instances #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a bit worried about this method... its sorta gross.... (not your fault). I opened a doc bug to figure out if there is a more clean way: ansible-collections/amazon.aws#713 |
|
Can we cancel/close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
For workshop deployments that provision 200 or more instances, when the teardown_lab playbook is called the following error is observed:
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
To reproduce, deploy enough student workbench environments to populate 200 or more instances and then attempt a teardown run.
NOTE: I have tested the changes in this PR against a 45 student
smart_mgmtworkshop (~360 instances), please test with other workshop types to confirm proper workshop teardown behavior.