Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint errors #150

Merged
merged 9 commits into from Oct 19, 2017
Merged

Fix lint errors #150

merged 9 commits into from Oct 19, 2017

Conversation

jmrodri
Copy link
Contributor

@jmrodri jmrodri commented Oct 19, 2017

Trying to fix travis linter checks.

Copy link
Contributor

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though personally I much prefer removing the 79 character line length requirement to formatting code around it

@fabianvf
Copy link
Contributor

Also I think if you pip install kubernetes before running Python setup.py install it'll be happy, probably an issue of bdist vs sdist or something stupid like that

@dymurray
Copy link
Contributor

Yeah agree with Fabian I hate the 79 char limit but big +1 for fixing travis.

Copy link
Contributor

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jesus!

@jmrodri jmrodri merged commit e56d538 into master Oct 19, 2017
@dymurray dymurray deleted the fixtravis branch March 28, 2018 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants