Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes playbooks for mediawiki #17

Merged
merged 3 commits into from
Jan 16, 2018

Conversation

rthallisey
Copy link
Contributor

No description provided.

@rthallisey
Copy link
Contributor Author

Copy link
Contributor

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commentary in ansibleplaybookbundle/postgresql-apb#23 (review) that impacts this change. Better to have the conversation in one place than 2.

Copy link
Contributor

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. When we can get rid of the scaling down it will be much cleaner.

- mediawiki
vars:
action: provision
cluster: openshift
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the other PR you used kubernetes as the default, why the difference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be kubernetes

value: '{{ route.route.spec.host }}'
image: docker.io/ansibleplaybookbundle/mediawiki123:latest
value: '{{ endpoint.endpoints.subsets[0].addresses[0].ip }}'
image: docker.io/jmontleon/mediawiki123:update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like a change you want to make.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we be using the mediawiki image now instead of mediawiki123?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My rebase scooped this up. It should be docker.io/ansibleplaybookbundle/mediawiki123:latest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I meant was the mediawiki123 image isn't being updated anymore, you should probably use the mediawiki image

@rthallisey
Copy link
Contributor Author

Going to merge this. I need it for the k8s and we can always fix it later if there are issues.

@rthallisey rthallisey merged commit ccbefd1 into ansibleplaybookbundle:master Jan 16, 2018
@rthallisey rthallisey deleted the k8s-playbook branch January 16, 2018 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants