-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes playbooks for mediawiki #17
Kubernetes playbooks for mediawiki #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commentary in ansibleplaybookbundle/postgresql-apb#23 (review) that impacts this change. Better to have the conversation in one place than 2.
aeabfd0
to
139628e
Compare
139628e
to
fc9dd8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. When we can get rid of the scaling down it will be much cleaner.
playbooks/provision.yml
Outdated
- mediawiki | ||
vars: | ||
action: provision | ||
cluster: openshift |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the other PR you used kubernetes
as the default, why the difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be kubernetes
roles/mediawiki/tasks/update.yml
Outdated
value: '{{ route.route.spec.host }}' | ||
image: docker.io/ansibleplaybookbundle/mediawiki123:latest | ||
value: '{{ endpoint.endpoints.subsets[0].addresses[0].ip }}' | ||
image: docker.io/jmontleon/mediawiki123:update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look like a change you want to make.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we be using the mediawiki
image now instead of mediawiki123
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My rebase scooped this up. It should be docker.io/ansibleplaybookbundle/mediawiki123:latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I meant was the mediawiki123
image isn't being updated anymore, you should probably use the mediawiki
image
Going to merge this. I need it for the k8s and we can always fix it later if there are issues. |
No description provided.