Notify the apb what cluster it's running on with extravars #577
Conversation
openshift-ci-robot
added
the
size/S
|
Changes Unknown when pulling 1042494 on rthallisey:extravars into ** on openshift:master**. |
| @@ -16,3 +16,8 @@ func (f fakeProvider) DestroySandbox(podName string, namespace string, targets [ | |||
| //TODO: Write tests for DestroySandbox using the fake kubernetes client | |||
| return | |||
| } | |||
|
|
|||
| func (f fakeProvider) GetRuntime() string { | |||
There was a problem hiding this comment.
I would like to see tests implemented for this change before giving the 👍
| @@ -198,6 +198,8 @@ func createExtraVars(context *Context, parameters *Parameters) (string, error) { | |||
| if context != nil { | |||
| paramsCopy["namespace"] = context.Namespace | |||
| } | |||
|
|
|||
| paramsCopy["cluster"] = runtime.Provider.GetRuntime() | |||
There was a problem hiding this comment.
I'm not sure if I believe this should be an extra variable or an environment variable that APBs should load and have default values for...
There was a problem hiding this comment.
I'm curious the reason that you have this as an argument instead of an environment variable to the APB.
There was a problem hiding this comment.
+1 for curiosity David. The reason I went with extravars is because it will overwrite the value of cluster right from the command line. Then we don't have to 1) add a default environment var to apb-base, 2) I don't need to rely on the user setting CLUSTER=kubernetes to run the playbooks locally, and 3) I can default the var right in the playbook:
vars:
cluster: kubernetesdocker run docker.io/ansibleplaybookbundle/mediawiki-apb provision --extra-vars cluster=kubernetes
ansible-playbook playbooks/provision.yaml --extra-vars "cluster=kubernetes"
openshift-ci-robot
added
size/M
Send the variable cluster as an extravar to the apb.
The executor file needs to be re done so tests can be created for each function.
openshift-ci-robot
added
size/L
|
Changes Unknown when pulling 07650ca on rthallisey:extravars into ** on openshift:master**. |
|
Changes Unknown when pulling 07650ca on rthallisey:extravars into ** on openshift:master**. |
|
@djzager I added the test in. Let me know if you have any more concerns. |
…#577) * Notify the apb what cluster it's running on with extravars Send the variable cluster as an extravar to the apb. * Add tests for GetRuntime * Remove extravars test since it uses the runtime pkg The executor file needs to be re done so tests can be created for each function.
Describe what this PR does and why we need it:
Send the variable 'cluster' as an extravar to the apb so it can identify which playbook to run based on the runtime.
Changes proposed in this pull request
depends-on: ansibleplaybookbundle/postgresql-apb#23
depends-on: ansibleplaybookbundle/mediawiki-apb#17