Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pro1: Sym doesn't wake phone #8

Closed
Spoil001 opened this issue Jan 26, 2020 · 4 comments
Closed

Pro1: Sym doesn't wake phone #8

Spoil001 opened this issue Jan 26, 2020 · 4 comments
Labels
done Fix/feature implemented

Comments

@Spoil001
Copy link

FinQWERTY 1.5.3 from PlayStore.
German for Physical QWERTZ.
@Spoil001
Copy link
Author

Spoil001 commented Jan 26, 2020 •
edited

A diff of the layouts shows that the following is missing from QWERTZ:

# orig SYM but SYM does not do anything at the moment
# so use as back/wakeup for now
map key 249 WAKEUP

@Spoil001
Copy link
Author

Is there a reason why WAKEUP is not on every key e.g. as fallback?

anssih added a commit that referenced this issue Jan 26, 2020
@anssih
pro1: Add missing sym = wakeup mapping to German QWERTZ (#8)
57db51f 
Fixes issue #8, reported by Spoil001.
@anssih
Copy link
Owner

anssih commented Jan 26, 2020

Is there a reason why WAKEUP is not on every key e.g. as fallback?

Someone tested that "fallback WAKEUP" did not work. I haven't had the time to check it myself yet as I just got the device.

The list of wakeup keys is hardcoded in Android frameworks/base/core/java/android/view/KeyEvent.java, function isWakeKey(). The best option would be to have e.g. KEYCODE_ESCAPE (and maybe other keys) added there.

@anssih anssih added the done Fix/feature implemented label Jan 28, 2020
@anssih
Copy link
Owner

anssih commented Feb 3, 2020

Fixed in v1.5.4, thanks.

@anssih anssih closed this as completed Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done Fix/feature implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anssih @Spoil001